Request log mem leak #110
Merged
Request log mem leak #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have at least 2 implementations of streams that do exactly this if you wanted to port one/both of them to java:
|
Foxcapades
approved these changes
Dec 2, 2024
Service/src/main/java/org/gusdb/wdk/service/filter/RequestLoggingFilter.java
Outdated
Show resolved
Hide resolved
Service/src/main/java/org/gusdb/wdk/service/filter/RequestLoggingFilter.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes all requests to temporary files, checks sizes and rejects request bodies that are too large. Then only logs body in service access log if response status code is 5xx, and even then truncates body to a reasonable level.
Possible enhancement would be to check max request size as we are writing to the file to save temp disk space and reject as soon as we go over the limit. Is it worth it?